Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking shutdown in doInitialize() when the NFC chip is not responding #145

Open
wants to merge 1 commit into
base: NCI2.0_PN7160
Choose a base branch
from

Conversation

agambier
Copy link

While testing the nfcDemo app with a PN7160 on a custom board on which the power supply was defective, I noticed that the function doInitialize()was in a dead lock.

While terminating the reading thread, the function phTmlNfc_CleanUp() is blocked in pthread_join().

This PR :

  • Tries to terminate the threads (read & write) with pthread_timedjoin_np()
  • Calls pthread_cancel() if the timed join failed.

Beside this PR, another PR in the kernel driver implements optionnal timeout during the read operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant