Testing with footer

NYPL · Apr 5, 2024 · 51edfc2 · 51edfc2
1 parent 3ccc643
commit 51edfc2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/pages/_document.tsx b/src/pages/_document.tsx
@@ -1,4 +1,5 @@
 import { Html, Head, Main, NextScript } from "next/document";
+import Script from "next/script";
 
 export default function Document() {
   return (
@@ -8,10 +9,11 @@ export default function Document() {
         <Main />
         <NextScript />
         <div id="nypl-footer"></div>
-        <script
+        <Script
           src="https://ds-header.nypl.org/footer.min.js?containerId=nypl-footer"
           async
-        ></script>
+          strategy="beforeInteractive"
+        ></Script>
       </body>
     </Html>
   );

diff --git a/src/pages/index.tsx b/src/pages/index.tsx
@@ -11,14 +11,18 @@ import NotificationBanner from "@/components/notificationBanner/notificationBann
 export default function Home(props: any = {}) {
   return (
     <>
-      <SkipNavigation target="#campaign-hero" />
+      <SkipNavigation target="#hero" />
       {/**
        * * @TODO: Header will need to be pulled into a reusable Layout component (DC Facelift phase 2)
        * * Let this be @7emansell 's problem if possible **/}
       <NotificationBanner />
       <Header />
       <TemplateAppContainer
-        breakout={<CampaignHero imageID={props.imageID} />}
+        breakout={
+          <div id="hero">
+            <CampaignHero imageID={props.imageID} />
+          </div>
+        }
         contentPrimary={<HomePageMainContent />}
       />
       <ExploreFurther />