Skip to content

Commit

Permalink
Merge branch 'main' into no_ref/update-links-to-division-pages
Browse files Browse the repository at this point in the history
  • Loading branch information
avertrees committed Nov 19, 2024
2 parents 10c25b3 + ca3a7b6 commit ce22470
Show file tree
Hide file tree
Showing 5 changed files with 117 additions and 108 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy_production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ jobs:
- name: Update ECS service
run: |
aws ecs update-service --cluster new-digitalcollections --service new-digitalcollections --force-new-deployment
aws ecs update-service --cluster new-digitalcollections-prod --service new-digitalcollections-prod --force-new-deployment
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

## [0.1.19] 2024-11-18

## Updated

- Updated collection card urls to use uuid
- Moved `/divisions` and `/divisions/[slug]` from behind middleware, now accessible
- Updated item card urls to use uuid
- Updated collection card urls to use legacy url
- Updated prod ECS cluster name to `new-digitalcollections-prod`

## [0.1.17] 2024-11-14

### Updated
Expand Down
3 changes: 1 addition & 2 deletions app/src/models/collectionCard.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// import { CollectionCardData } from "app/types/Collection";
import { imageURL } from "../utils/utils";
import { stringToSlug } from "../utils/utils";
import { parseBoolean } from "../utils/utils";

// TODO: Connect to typescript interface for CollectionCardData
Expand All @@ -16,7 +15,7 @@ export class CollectionCardModel {
constructor(data: any) {
this.uuid = data.uuid;
this.title = data.title;
this.url = data.url.replace("https://digitalcollections.nypl.org", "");
this.url = `/collections/${data.uuid}`;
this.imageID = data.image_id || data.imageID;
this.imageURL = imageURL(data.imageID, "full", "288,", "0");
this.numberOfDigitizedItems =
Expand Down
Loading

0 comments on commit ce22470

Please sign in to comment.