Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DR-2464 hero component VQA and Accessibility updates #14

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

avertrees
Copy link
Collaborator

Ticket:

This PR does the following:

  • Updates the alt text for the image in the Hero Component to use the title of the featured item instead of "example image." Note: this is currently hard coded and will need to update this to be dynamic when we implement the featured item tickets.
  • Added an aria label for the "Learn more" link with the text "Learn more about harmful content".
  • Updated the Heading (desktop) and Heading (desktop) to be 54px and 42px, respectfully, by using the size "heading2"

How has this been tested?

Accessibility concerns or updates

Checklist:

  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digital-collections ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 5:11pm

@avertrees avertrees changed the title Feature/dr 2464 update hero component DR-2464 hero component VQA and Accessibility updates Oct 20, 2023
@avertrees avertrees merged commit 3157b81 into main Oct 25, 2023
3 checks passed
@avertrees avertrees deleted the feature/DR-2464-update-hero-component branch July 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants