-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DR-2443 Featured items endpoint #15
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, this is working well. A question that might change a few things in this PR: should the feature items be conceptually the same as a lane? If not, perhaps this needs it's own API route such as /api/featuredItems
?
I'm not sure how it's currently handled or the mental model in the current app, but what do you both (@avertrees ) think?
I was also going to suggest an update to the API Route to something like /api/featuredItems or /api/featured/items. In the ticket, it's expected to be /api/lanes/items but retrospectively that is not very intuitive (my fault) and we have the flexibility to change it. Note though that we will need to update the AC in the ticket to reflect whichever API route we choose to go with. |
Planning to discuss tomorrow morning before stand up and will edit accordingly! |
Ticket:
Fixes JIRA ticket DR-2443
This PR does the following:
How has this been tested?
Tested locally.
Accessibility concerns or updates
N/A.
Checklist: