DR-2574 Template for homepage #18
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -17,4 +17,15 @@ describe("Home", () => { | |||
| }); | |||
| expect(header).toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| it("renders the expected text content", () => { | |||
| const { getByText } = render(<Home />); | |||
There was a problem hiding this comment.
Best I could come up with for unit tests on components that don't actually have any content, but is there a more thorough way to do this?
There was a problem hiding this comment.
This is okay! We also had a hard time testing this on the DS. The accessibility test covers what we want as well.
src/pages/index.tsx
Outdated
| return <CampaignHero />; | ||
| return ( | ||
| <> | ||
| <SkipNavigation /> |
There was a problem hiding this comment.
Thanks for adding this, I forgot about this. It also needs a bit more clarity from Clare or Lana about where the "Skip to Main Content" link should go to. The link goes to #mainContent but there's no element on the page with this id. Can you add it to the h1 in the Hero (currently has campaign-hero) for now?
We can bring this up once the swim lanes are complete -- should we point to the hero heading or the first swim lane?
src/pages/index.tsx
Outdated
| return ( | ||
| <> | ||
| <SkipNavigation /> | ||
| <Template> |
There was a problem hiding this comment.
Just curious, did you try the TemplateAppContainer component as well? You don't need to change it but just wondering if there were any issues with it.
There was a problem hiding this comment.
Refactored to use TemplateAppContainer
src/pages/index.tsx
Outdated
| <p>Rest of swim lanes</p> | ||
| <p>Explore further links</p> | ||
| </TemplateContent> | ||
| <TemplateFooter> |
There was a problem hiding this comment.
The NYPL Footer will go in a different location so this is okay to remove.
There was a problem hiding this comment.
Does this mean remove the template footer entirely?
7emansell
removed
question
Ticket:
Fixes JIRA ticket DR-2574
This PR does the following:
How has this been tested?
Tested locally.
Accessibility concerns or updates
N/A.
Checklist: