-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLOCKED: Launch prep: Update links to /divisions and /divisions/:slug pages #207
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -10,7 +10,7 @@ export const dcNavLinks = [ | |||
text: "Collections", | |||
}, | |||
{ | |||
href: `${DC_URL}/divisions`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test "has links" in app/src/components/navMenu/navMenu.test.tsx
passes but it shouldn't. The divisions expectation still has DC_URL
in the test. It only passes because the APP_ENV
env var is set to "development" by default, so then DC_URL
is an empty string. Update the test and we should think of a test environment set of env var values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same situation in app/src/components/navMenu/mobileNavMenu.test.tsx
.
Ticket:
This PR does the following:
Checklist: