Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOCKED: Launch prep: Update links to /divisions and /divisions/:slug pages #207

Closed
wants to merge 9 commits into from

Conversation

avertrees
Copy link
Collaborator

@avertrees avertrees commented Oct 4, 2024

Ticket:

This PR does the following:

  • updates nav link on homepage to point to to /divisions
  • updates links on the all divisions page to point to the divisions landing pages in dc facelift
  • removes redirect for /divisions and /divisions/:slug pages

Checklist:

  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.
  • I have updated the CHANGELOG.md.

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digital-collections ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 4:18pm

@@ -10,7 +10,7 @@ export const dcNavLinks = [
text: "Collections",
},
{
href: `${DC_URL}/divisions`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test "has links" in app/src/components/navMenu/navMenu.test.tsx passes but it shouldn't. The divisions expectation still has DC_URL in the test. It only passes because the APP_ENV env var is set to "development" by default, so then DC_URL is an empty string. Update the test and we should think of a test environment set of env var values.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same situation in app/src/components/navMenu/mobileNavMenu.test.tsx.

@avertrees avertrees changed the title Launch prep: Update links to /divisions and /divisions/:slug pages BLOCKED: Launch prep: Update links to /divisions and /divisions/:slug pages Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants