cleanup variables after reverse proxy launch #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7emansell
approved these changes
Nov 26, 2024
EdwinGuzman
approved these changes
Nov 27, 2024
| @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ## Removed | |||
| - removed unneccessary variables post reverse proxy launch | |||
There was a problem hiding this comment.
Nit: "unnecessary environment variables"
| # Old DC url | ||
| DC_URL='' # OR https://qa-digitalcollections.nypl.org OR https://digitalcollections.nypl.org | ||
| # Base DC url | ||
| # DC_URL='' |
There was a problem hiding this comment.
This is removed in the ENVIRONMENTVARS.md file, so it should be removed here too. I don't see any references to it anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Open Questions
How has this been tested? How should a reviewer test this?
Accessibility concerns or updates
Checklist: