DR-3305 fallback for featured item updates post reverse proxy launch #254
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| foregroundImageSrc: "/482815.jpg", | ||
| uuid: "510d47d9-4f93-a3d9-e040-e00a18064a99", | ||
| title: "Watuppa, From water front, Brooklyn", | ||
| href: "https://qa-digitalcollections.nypl.org/items/510d47d9-4f93-a3d9-e040-e00a18064a99", |
There was a problem hiding this comment.
Doesn't this risk linking to QA if this was in production?
There was a problem hiding this comment.
Link to /items/510d47d9-4f93-a3d9-e040-e00a18064a99 to be relative to the environment its in.
| href: "https://digitalcollections.nypl.org/items/510d47d9-4f93-a3d9-e040-e00a18064a99", | ||
| }, | ||
| numberOfDigitizedItems: "875,861", | ||
| const defaultFeaturedItem: FeaturedItemDataType = { |
There was a problem hiding this comment.
The test fails because this was updated but the reference in campaignHero.tsx was not. In https://github.com/NYPL/digital-collections/blob/main/app/src/components/featuredItem/campaignHero.tsx#L13 you can remove the [appConfig["environment"] as ENV_KEY] and also delete the unused imports.
Because you're importing the object from another file, you can make a copy by doing const defaultFeaturedItemResponse = { ...defaultFeaturedItem };.
You're not modifying defaultFeaturedItem in campaignHero.tsx so it might be safe to just use it directly in the useState, but I think it's better practice to make a copy to make it immutable.
avertrees
deleted the
feature/DR-3305/update-default-featured-item-data
branch
Ticket:
This PR does the following:
Open Questions
How has this been tested? How should a reviewer test this?
Accessibility concerns or updates
Checklist: