Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DR-2794: New feedback form credentials #257

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

7emansell
Copy link
Collaborator

@7emansell 7emansell commented Dec 2, 2024

Ticket:

This PR does the following:

  • Updates the credentials the app uses for Google Sheets API: GET NEW ENVIRONMENT VARS FROM ME
  • Also corrects the env.example– there are some variables in there that are not actually used for the Google Sheets access or anything

Open Questions

How has this been tested? How should a reviewer test this?

Get the new vars, then run it locally, enter feedback, check that the email updating the form is [email protected] (not digital-collections@digital-collections-408515.iam.gserviceaccount.com).

Accessibility concerns or updates

Checklist:

  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.
  • I have updated the CHANGELOG.md.

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digital-collections ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 7:37pm

@7emansell 7emansell merged commit 176d22e into main Dec 3, 2024
4 checks passed
@7emansell 7emansell deleted the DR-2794/new-feedback-credentials branch December 3, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants