update label text on sort menu for all collections page #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7emansell
approved these changes
Dec 20, 2024
| @@ -159,11 +160,12 @@ export function CollectionsPage({ data, params, renderCollections }) { | |||
| onChange: (e) => handleSearchChange(e), | |||
| }} | |||
| onSubmit={handleSearchSubmit} | |||
| labelText={""} | |||
| labelText="Search Collections by title" | |||
| aria-label="Search Collections by title" | |||
There was a problem hiding this comment.
major nit but should collections be capitalized
There was a problem hiding this comment.
Hmm good point. I don't think you need the aria-label, the labelText should cover that.
EdwinGuzman
reviewed
Dec 20, 2024
|
@EdwinGuzman the aria-label was added for the a11y test and it did not fix the issue. I can remove it for now or update "Collections" to be lowercase but the DS docs do say that the labelText should be enough to populate the aria label. I made another ticket for the a11y tests: DR-3342 FE | Write a11y tests for all phase 2 pages |
EdwinGuzman
approved these changes
Dec 20, 2024
7emansell
pushed a commit
that referenced
this pull request
Dec 20, 2024
update label text on sort menu for all collections page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
Open Questions
How has this been tested? How should a reviewer test this?
Accessibility concerns or updates
Checklist: