Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1572: deprecate secondary and fiftyFifty variants for Hero #1445

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

bigfishdesign13
Copy link
Collaborator

Fixes JIRA ticket DSD-1572

This PR does the following:

  • Deprecates the "secondary" and "fiftyFifty" variants of the Hero component.

How has this been tested?

  • local Storybook

Accessibility concerns or updates

  • n/a

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 4:57pm

@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed Needs Review Pull requests that are ready for peer review. labels Oct 20, 2023
@bigfishdesign13 bigfishdesign13 merged commit af1e395 into development Oct 20, 2023
4 checks passed
@bigfishdesign13 bigfishdesign13 deleted the DSD-1572/deprecate-hero-variants branch October 20, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants