Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1614: Upgrading to Storybook v7.5.1 #1449

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

bigfishdesign13
Copy link
Collaborator

@bigfishdesign13 bigfishdesign13 commented Oct 26, 2023

Fixes JIRA ticket DSD-1614

This PR does the following:

  • Upgraded to Storybook v7.5.1
  • IMPORTANT: make sure to run npm i before building the app

How has this been tested?

  • local Storybook

Accessibility concerns or updates

  • n/a

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 3:23pm

@bigfishdesign13 bigfishdesign13 changed the title Upgrading to Storybook v7.5.1 DSD-1614: Upgrading to Storybook v7.5.1 Oct 26, 2023
@bigfishdesign13 bigfishdesign13 added the Needs Review Pull requests that are ready for peer review. label Oct 26, 2023
Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works locally for me and storybook docs look fine. FeedbackBox was pointed out but the iframe strictness is okay. We should point it out to Alkim next time we have an update so he's aware of this new Storybook functionality.

@bigfishdesign13
Copy link
Collaborator Author

bigfishdesign13 commented Oct 26, 2023

The branch has been tested by numerious devs and in all cases the app built and functioned without issue. Additionally, Alkim has performed a general test of the front-end of the site and he did not find any issues. Based on all of that that, along with Edwin's review, the PR has been approved to move forward.

@bigfishdesign13 bigfishdesign13 merged commit fc1e77b into development Oct 26, 2023
4 checks passed
@bigfishdesign13 bigfishdesign13 deleted the storybook-7.5.1 branch October 26, 2023 19:08
@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed Needs Review Pull requests that are ready for peer review. labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants