Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1852: SubNav Menu Component #1697

Merged
merged 111 commits into from
Nov 25, 2024
Merged

DSD-1852: SubNav Menu Component #1697

Show file tree
Hide file tree
Changes from 110 commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
7a350f2
SubNav functionality in progress
deepikagonuguntla Oct 31, 2024
560c938
Added code comments
deepikagonuguntla Nov 4, 2024
e37e579
implemented subnav
deepikagonuguntla Nov 4, 2024
c410eb0
implemented subnav functionality
deepikagonuguntla Nov 4, 2024
e27fb4e
added Icon styles
deepikagonuguntla Nov 4, 2024
67adba4
added Icon styles
deepikagonuguntla Nov 4, 2024
7f4ae08
added button styles
deepikagonuguntla Nov 4, 2024
4d4633d
added highlight color
deepikagonuguntla Nov 5, 2024
9ff0dc8
Added href in subnav Link
deepikagonuguntla Nov 5, 2024
5e0750d
Added href in subnav Link
deepikagonuguntla Nov 5, 2024
c114cf0
Added common styles for priamry and secondary
deepikagonuguntla Nov 5, 2024
75ed80d
Added common styles for priamry and secondary
deepikagonuguntla Nov 5, 2024
3967ff9
Merge branch 'development' of https://github.com/NYPL/nypl-design-sys…
deepikagonuguntla Nov 5, 2024
1aec077
Added common styles for priamry and secondary
deepikagonuguntla Nov 5, 2024
1baa384
Added accessibility links
deepikagonuguntla Nov 5, 2024
f3e7e47
added test cases
deepikagonuguntla Nov 5, 2024
b0fcff4
added test cases
deepikagonuguntla Nov 5, 2024
95d9ec1
Merge branch 'development' into DSD-1852/sub-nav-menu
gonuguntla Nov 5, 2024
c5c4e27
implemented test cases
deepikagonuguntla Nov 5, 2024
f42e3e2
Merge branch 'DSD-1852/sub-nav-menu' of https://github.com/NYPL/nypl-…
deepikagonuguntla Nov 5, 2024
08dc08e
added changelog
deepikagonuguntla Nov 5, 2024
7068b34
added changelog
deepikagonuguntla Nov 5, 2024
ac8c21d
added List for subnav menu
deepikagonuguntla Nov 6, 2024
8407351
added List for subnav menu
deepikagonuguntla Nov 6, 2024
4d32bca
added mobile viewport condition
deepikagonuguntla Nov 6, 2024
014c8e5
added mobile viewport condition
deepikagonuguntla Nov 6, 2024
231c8e7
simplifying the styles
bigfishdesign13 Nov 6, 2024
77ff800
merge from base branch
bigfishdesign13 Nov 6, 2024
d68e11f
used nypl design system List
deepikagonuguntla Nov 6, 2024
ad9d556
used nypl design system List
deepikagonuguntla Nov 6, 2024
08804bb
used nypl design system List
deepikagonuguntla Nov 6, 2024
2c8e20b
used nypl design system List
deepikagonuguntla Nov 6, 2024
912d207
additional style adjustments
bigfishdesign13 Nov 6, 2024
d8b298d
Merge branch 'DSD-1852/sub-nav-menu' into DSD-1852/sub-nav-styles
bigfishdesign13 Nov 6, 2024
1e50f2a
Merge pull request #1698 from NYPL/DSD-1852/sub-nav-styles
gonuguntla Nov 6, 2024
dbcfa98
refactor code
deepikagonuguntla Nov 7, 2024
c211aa1
refactor code
deepikagonuguntla Nov 7, 2024
b43445a
Merge branch 'development' into DSD-1852/sub-nav-menu
gonuguntla Nov 7, 2024
f2bb671
added link styles for primary sections
deepikagonuguntla Nov 7, 2024
5890432
added link styles for primary sections
deepikagonuguntla Nov 7, 2024
f95d8eb
Added subnav styles
deepikagonuguntla Nov 11, 2024
7ec6c42
Added subnav styles
deepikagonuguntla Nov 11, 2024
be7ce03
Added subnav styles
deepikagonuguntla Nov 11, 2024
f90ea93
Added subnav styles
deepikagonuguntla Nov 11, 2024
b70356c
Added subnav styles
deepikagonuguntla Nov 11, 2024
4a8d906
added test cases
deepikagonuguntla Nov 11, 2024
6bd82fb
added test cases
deepikagonuguntla Nov 11, 2024
ecb2a51
added font size
deepikagonuguntla Nov 12, 2024
b36735a
added font size
deepikagonuguntla Nov 12, 2024
b225717
added log warning
deepikagonuguntla Nov 12, 2024
c4732be
removed selected item
deepikagonuguntla Nov 12, 2024
40ec790
removed selected item
deepikagonuguntla Nov 12, 2024
7c80541
removed selected item
deepikagonuguntla Nov 12, 2024
dfe8870
fixed lint issues
deepikagonuguntla Nov 12, 2024
cfeb4b5
fixed lint issues
deepikagonuguntla Nov 12, 2024
c1a9adc
button type and action type always fixed
deepikagonuguntla Nov 12, 2024
95a7041
working on stories and docs
bigfishdesign13 Nov 12, 2024
602d28f
merge from github and some adjustments
bigfishdesign13 Nov 12, 2024
e7340f1
stories and docs
bigfishdesign13 Nov 13, 2024
b40d4ba
added li elements
deepikagonuguntla Nov 13, 2024
1939e19
added story for placement
bigfishdesign13 Nov 13, 2024
523dc7c
Merge branch 'DSD-1852/sub-nav-menu' of https://github.com/NYPL/nypl-…
bigfishdesign13 Nov 13, 2024
6f672ac
fixed alignment and max width
bigfishdesign13 Nov 13, 2024
389cc11
better spacing styles for lists
bigfishdesign13 Nov 13, 2024
2cd36ae
added isselected in subnav buttons and links
deepikagonuguntla Nov 13, 2024
8de0ccc
added isselected in subnav buttons and links
deepikagonuguntla Nov 13, 2024
428212b
Merge branch 'DSD-1852/sub-nav-menu' of https://github.com/NYPL/nypl-…
deepikagonuguntla Nov 13, 2024
cef3b15
Added subnav children styles
deepikagonuguntla Nov 13, 2024
e61cc52
spacing adjustments to accommodate focus ring
bigfishdesign13 Nov 13, 2024
0c11fe0
Merge branch 'DSD-1852/sub-nav-menu' of https://github.com/NYPL/nypl-…
bigfishdesign13 Nov 13, 2024
1db6c06
Added screen reader for buttons
deepikagonuguntla Nov 13, 2024
33298d2
Added screen reader for buttons
deepikagonuguntla Nov 13, 2024
8b147c4
Merge branch 'DSD-1852/sub-nav-menu' of https://github.com/NYPL/nypl-…
bigfishdesign13 Nov 13, 2024
2459dcb
cleanup of screenreaderOnlyText values
bigfishdesign13 Nov 13, 2024
f5eee77
Added defaultselect styles
deepikagonuguntla Nov 13, 2024
6aa199c
Merge branch 'DSD-1852/sub-nav-menu' of https://github.com/NYPL/nypl-…
deepikagonuguntla Nov 13, 2024
efbba86
added story for horizontal scrolling
bigfishdesign13 Nov 14, 2024
6d7b8f4
Create a newHook for fadestyles
deepikagonuguntla Nov 14, 2024
7a79a72
Create a newHook for fadestyles
deepikagonuguntla Nov 14, 2024
579a60e
fixed li styles
deepikagonuguntla Nov 14, 2024
81ba3c3
added test cases
deepikagonuguntla Nov 14, 2024
461e632
added test cases
deepikagonuguntla Nov 14, 2024
dacf909
added documentation for fading hook
deepikagonuguntla Nov 14, 2024
98aa541
aria current added for buttons
deepikagonuguntla Nov 14, 2024
7202852
fixed flickering issue
deepikagonuguntla Nov 15, 2024
432c457
fixed flickering issue
deepikagonuguntla Nov 15, 2024
553539f
better description on how to use isSelected prop
bigfishdesign13 Nov 15, 2024
7977744
added fadeeffect styles
deepikagonuguntla Nov 15, 2024
7230bd1
Merge branch 'DSD-1852/sub-nav-menu' of https://github.com/NYPL/nypl-…
deepikagonuguntla Nov 15, 2024
73fbf92
package-lock
bigfishdesign13 Nov 15, 2024
5222d59
Fixed list styles
deepikagonuguntla Nov 15, 2024
db657d6
Wrapped List in div
deepikagonuguntla Nov 15, 2024
9e1f26f
added documentation
deepikagonuguntla Nov 15, 2024
2bd0417
Removed args
deepikagonuguntla Nov 18, 2024
0aeb859
fixed code review comments
deepikagonuguntla Nov 18, 2024
d0ac832
fixed code review comments
deepikagonuguntla Nov 18, 2024
e409651
resolved conflicts
deepikagonuguntla Nov 18, 2024
3a5e5d4
resolved conflicts
deepikagonuguntla Nov 18, 2024
6f8650e
instead of div updated with Box
deepikagonuguntla Nov 18, 2024
e2e1100
added development package.lock file
deepikagonuguntla Nov 18, 2024
504c260
updated with latest npm package
deepikagonuguntla Nov 18, 2024
040c5b6
updated with latest npm package
deepikagonuguntla Nov 18, 2024
359a4b6
removed args
deepikagonuguntla Nov 18, 2024
d25a333
added example
deepikagonuguntla Nov 19, 2024
4399db5
removing important from light mode styles
bigfishdesign13 Nov 19, 2024
7c003c9
one final style adjustment for secondaryActions
bigfishdesign13 Nov 19, 2024
fe48ca5
fixed a11y violation in 'placement' story
bigfishdesign13 Nov 19, 2024
a32764c
Added styles
deepikagonuguntla Nov 25, 2024
66db791
Merge branch 'DSD-1852/sub-nav-menu' of https://github.com/NYPL/nypl-…
deepikagonuguntla Nov 25, 2024
a4404d2
added faceeffect styles in hook
deepikagonuguntla Nov 25, 2024
4f4e54c
merge from development branch
bigfishdesign13 Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Currently, this repo is in Prerelease. When it is released, this project will ad

- Adds the `"contentFilterRelease"` option to the `Icon` component.
- Adds the `"socialX"` option to the `Icon` component.
- Adds the `"Subnav"`component.
- Adds the `heading7` and `heading8` to the font size design tokens.
- Adds the `heading7` and `heading8` options for the `size` prop in the `Heading` component.

Expand Down
Loading
Loading