Merge RENO-4242: Update LPA Code from Main to QA #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial github actions
Merge main
Update github actions
Move ci.yml to workflows
Add production deployment
Update package.json version to 2.0.0
Tgr production
Change "my" to "lp" as code for LPA at src/data/ilsLibraryList.ts.
RENO-4242: Update LPA Code
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EdwinGuzman
reviewed
Nov 7, 2024
| run: npm run test | ||
| publish_qa: | ||
| needs: test | ||
| if: github.ref == 'refs/heads/tgr-qa' |
There was a problem hiding this comment.
Can you update 'refs/heads/tgr-qa' to 'refs/heads/qa'?
| aws ecs update-service --cluster nypl-library-card-app-qa --service nypl-library-card-app-qa --force-new-deployment | ||
| publish_production: | ||
| needs: test | ||
| if: github.ref == 'refs/heads/tgr-production' |
There was a problem hiding this comment.
Can you update 'refs/heads/tgr-production' to 'refs/heads/production'?
|
Requires update to Github actions prior to merge. New to be PR created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change "my" to "lp" as code for LPA at src/data/ilsLibraryList.ts.