Add patron data methods and database connection retries #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
37
to
62
| while attempt_count <= retry_count: | ||
| try: | ||
| try: | ||
| self.conn = mysql.connector.connect( | ||
| host=self.host, | ||
| port=self.port, | ||
| database=self.database, | ||
| user=self.user, | ||
| password=self.password, | ||
| **kwargs) | ||
| except (mysql.connector.Error): | ||
| if attempt_count < retry_count: | ||
| self.logger.info('Failed to connect -- retrying') | ||
| time.sleep(backoff_factor ** attempt_count) | ||
| attempt_count += 1 | ||
| else: | ||
| raise | ||
| else: | ||
| break | ||
| except Exception as e: | ||
| self.logger.error( | ||
| 'Error connecting to {name} database: {error}'.format( | ||
| name=self.database, error=e)) | ||
| raise MySQLClientError( | ||
| 'Error connecting to {name} database: {error}'.format( | ||
| name=self.database, error=e)) from None |
There was a problem hiding this comment.
Small nit & I'm not sure how to fix this, but this try-except block is quite nested and not super readable -- is there a way around this? I see what you're trying to do / it makes sense, but I think there is a way around the additional else on line 54
There was a problem hiding this comment.
Yeah it's a little convoluted -- the idea was I only wanted to have to log and raise the ClientError once and I also wanted non-database Exceptions to still get thrown immediately. I moved the break to within the try block -- hopefully that makes it at least a little better?
fatimarahman
previously approved these changes
Nov 22, 2024
fatimarahman
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG for more information. Most of the existing DE pipelines use one of the methods in patron_data_helper, so a followup to this PR will be replacing all of that code. Note that the database work (the first commit) is unrelated to the patron data work (the second commit).