Restore fragments

NYPL · Dec 11, 2024 · 1645a55 · 1645a55
1 parent 702b3ec
commit 1645a55
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/src/components/BibPage/BibDetail.tsx b/src/components/BibPage/BibDetail.tsx
@@ -61,14 +61,9 @@ const DetailElement = (label: string, listChildren: ReactNode[]) => {
     <>
       <dt>{label}</dt>
       <dd>
-        <List
-          noStyling
-          data-testid={kebabCase(label)}
-          type="ol"
-          listItems={listChildren.map((listElement) => (
-            <>{listElement}</>
-          ))}
-        />
+        <List noStyling data-testid={kebabCase(label)} type="ol">
+          {listChildren}
+        </List>
       </dd>
     </>
   )

diff --git a/src/components/HoldPages/HoldConfirmationItemDetails.tsx b/src/components/HoldPages/HoldConfirmationItemDetails.tsx
@@ -26,15 +26,19 @@ const HoldConfirmationItemDetails = ({
       mb="l"
       mt={0}
     >
-      {pickupLocationLabel && (
+      {pickupLocationLabel ? (
         <PlainTextElement
           label="Pickup location"
           value={[pickupLocationLabel]}
         />
+      ) : (
+        <></>
       )}
       <PlainTextElement label="Call number" value={[item.callNumber]} />
-      {item.barcode && (
+      {item.barcode ? (
         <PlainTextElement label="Barcode" value={[item.barcode]} />
+      ) : (
+        <></>
       )}
     </List>
   )

diff --git a/src/components/HoldPages/HoldRequestItemDetails.tsx b/src/components/HoldPages/HoldRequestItemDetails.tsx
@@ -29,8 +29,10 @@ const HoldRequestItemDetails = ({ item }: HoldRequestItemDetailsProps) => {
         link="internal"
       />
       <PlainTextElement label="Call number" value={[item.callNumber]} />
-      {item.volume && (
+      {item.volume ? (
         <PlainTextElement label="Volume/date" value={[item.volume]} />
+      ) : (
+        <></>
       )}
     </List>
   )