-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCC-4236: Username for My Account 2.0 #397
Merged
+698
−94
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
766b558
Start of username
7emansell 7e67c6e
Pulling out status banner
7emansell 47219eb
Start of username validation api route
7emansell cd54635
Removing discovery links from config and updating nyplApiClient
7emansell f116cf8
Username form and cleanup in other files
7emansell a6f7684
Tests (need more once deletion is confirmed)
7emansell e52407e
Clean up
7emansell 673d296
One more test
7emansell bc995e2
Typooo
7emansell f1a87f8
Moving UsernameForm into list
7emansell ee979fc
Typo/import clean up
7emansell 28e698d
Simplifying ternaries
7emansell 303cf48
Removing ternaries and fixing alignment
7emansell d240835
Removing DISCOVERY_API_NAME
7emansell 8ec5985
Removing more ternary
7emansell 4a5e036
Styling updates
7emansell d78b943
Tweaking error handling on helper
7emansell 013d510
Changing deletion strategy
7emansell b17b5a1
Adding deletion test and defining tempInput null meaning
7emansell 6570b9f
Commenting
7emansell 0bcf57d
More clean up
7emansell bc4f37e
Variable name updates
7emansell 63aa14e
More styling tweaks
7emansell f1e65a6
styling
7emansell 2863e93
Starting to fix helper error text
7emansell 5e720be
using ui.link.primary where possible
7emansell 3b317c3
more changes
7emansell e7bf689
Tests corrected
7emansell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Styling updates
commit 4a5e03649cbfe559c03894802d00e31d0dc08295
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should happen automatically when
isInvalid
is true. Or is this because the additional!validateUsername
check below affects the text color?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because the label and the invalid text are the same copy, and render in the same place (below the field). Since that's not how this component expects to work, I'm manually making the label text become the invalid text when needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use
helperText
here instead oflabelText
? It looks like the helper text is automatically with the correct styling for this.