Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCC-3762 - Hold Confirmation Server Functions #404

Merged
merged 7 commits into from
Nov 26, 2024
Merged

SCC-3762 - Hold Confirmation Server Functions #404

merged 7 commits into from
Nov 26, 2024

Conversation

dgcohen
Copy link
Contributor

@dgcohen dgcohen commented Nov 22, 2024 •
edited
Loading

Draft PR for server-side Hold Confirmation functions. The getter functions are mostly done but they need to be integrated and tested.

TODO:

  • Render ineligibility messages and set new status on Hold form pages
  • Fetch item in confirmation page and show details

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
research-catalog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 2:34pm

@dgcohen dgcohen changed the base branch from main to hold-pages November 22, 2024 22:17
@EdwinGuzman
Copy link
Member

I will merge this into hold-pages but first fix the conflicts. This will be merged with existing known issues to be fixed at a later time.

@EdwinGuzman EdwinGuzman marked this pull request as ready for review November 26, 2024 02:50
@EdwinGuzman EdwinGuzman merged commit 5d8940a into hold-pages Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgcohen @EdwinGuzman