My Account 2.0 #407
My Account 2.0 #407
Conversation
SCC-4253: Edit email in My Account 2.0
SCC-4236: Username for My Account 2.0
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ) | ||
| }) | ||
|
|
||
| test("successfully sets patron data if every field is valid", async () => { |
There was a problem hiding this comment.
is this the correct title for this test?
There was a problem hiding this comment.
What might make more sense as the title for this test?
| expect(screen.getByRole("button", { name: /edit/i })).toBeInTheDocument() | ||
| }) | ||
|
|
||
| it("renders correctly with when user has no username", () => { |
There was a problem hiding this comment.
can you add a few more tests here? there are a bunch of different combinations of isEditing/hasUsername/etc that are represented by these ternaries here.
This doesn't have to block QA deployment, but these expectations for these different cases should be tested. It will help with making updates from the QA process.
There was a problem hiding this comment.
I agree there should be more tests but they can also be written while the team starts the QA cycle.
| expect(screen.getByRole("button", { name: /edit/i })).toBeInTheDocument() | ||
| }) | ||
|
|
||
| it("renders correctly with when user has no username", () => { |
There was a problem hiding this comment.
I agree there should be more tests but they can also be written while the team starts the QA cycle.
Ticket:
This PR does the following:
How has this been tested?
Accessibility concerns or updates
Checklist: