Code

SCC-3762 - Hold Confirmation Details#413

Code

Merged

dgcohen merged 54 commits intohold-pagesNYPL/research-catalog:hold-pagesfrom SCC-3762/hold-confirmation-server-functionsNYPL/research-catalog:SCC-3762/hold-confirmation-server-functionsCopy head branch name to clipboardDec 12, 2024

+435-38

Commits

Commits on Dec 2, 2024

• Merge branch 'main' of github.com:NYPL/research-catalog into SCC-3762/hold-confirmation-server-functions

  dgcohen

  committed
  d9fff88

• Merge branch 'hold-pages' of github.com:NYPL/research-catalog into SCC-3762/hold-confirmation-server-functions

  dgcohen

  committed
  ddaa479

• Initialize HoldPageStatusMessage component

  dgcohen

  committed
  4a78c27

• Rename to HoldPageStatusMessage

  dgcohen

  committed
  01bc099

Commits on Dec 3, 2024

• Update renamed variable references

  dgcohen

  committed
  2ba3e42

• More reference name changes

  dgcohen

  committed
  584843d

• Start error message refactor

  dgcohen

  committed
  a8121d1

• Add patron error messages

  dgcohen

  committed
  faac548

• Rename pageStatus to errorStatus

  dgcohen

  committed
  7e77b23

• Check patron eligibility in hold request getServerSideProps

  dgcohen

  committed
  a1cdffa

• Rename HoldRequestBanner to HoldRequestErrorBanner

  dgcohen

  committed
  dd94ac1

• Make patron errors a DS list component

  dgcohen

  committed
  bfb4769

• Remove 404 redirect on patron eligibility fetch failure

  dgcohen

  committed
  d5f09ef

• Remove patron error fallback from body

  dgcohen

  committed
  eeebb65

• Move error copy to constants file

  dgcohen

  committed
  a1d35f5

• Fix error handling on edd page

  dgcohen

  committed
  0582787

• Remove brackets from redirect path

  dgcohen

  committed
  9317001

• Remove check on eligibility boolean

  dgcohen

  committed
  c186bc9

• Add top margin to banner body

  dgcohen

  committed
  c15b8f5

• Add switch statement to client side fetch

  dgcohen

  committed
  69e359b

• Add eligibility check to api route

  dgcohen

  committed
  b14187d

Commits on Dec 5, 2024

• Add variable with failed edd server responses

  dgcohen

  committed
  87d3528

• Don't show reasons list when none is active

  dgcohen

  committed
  2911eb9

Commits on Dec 6, 2024

• Don't return reason when there isn't a specific eligibility reason

  dgcohen

  committed
  3872336

• Add top margin to reasons box

  dgcohen

  committed
  cf3bda6

Commits on Dec 9, 2024

• Render item details on confirmation page

  dgcohen

  committed
  7f5e309

• Remove console logs

  dgcohen

  committed
  8d9b937

• Render back to search link

  dgcohen

  committed
  580b160

• Add margin to search link

  dgcohen

  committed
  45b8db3

• Add separate item table for confirmation page

  dgcohen

  committed
  50e4b4e

• Remove redundant item result prop

  dgcohen

  committed
  ff5e32d

• Remove query from mocked gerServerSideProps calls

  dgcohen

  committed
  3fa04f5

• Fix bib item fetching call

  dgcohen

  committed
  6fcc965

• Merge branch 'hold-pages' of github.com:NYPL/research-catalog into SCC-3762/hold-confirmation-server-functions

  dgcohen

  committed
  3a72e57

• Update prop names on hold item details components

  dgcohen

  committed
  76d2837

• Remove duplicate item initialization

  dgcohen

  committed
  fdd8d6b

• Remove NextResponse from hold request api handler

  dgcohen

  committed
  2ed9b4c

• Rename fetchHoldRequestEligibility to fetchPatronEligibility

  dgcohen

  committed
  fa7dfa3

• Add tests for fetching patron eligibility status

  dgcohen

  committed
  5c108a7

• Fix patron eligibility error handling and add tests for fetchHoldDetails

  dgcohen

  committed
  7439343

Commits on Dec 10, 2024

• Separate confirmation related changes

  dgcohen

  committed
  22d5f4e

• Restore config file

  dgcohen

  committed
  06a100b

• Add confirmation page tests

  dgcohen

  committed
  8be9f65

• Merge branch 'hold-pages' of github.com:NYPL/research-catalog into SCC-3762/hold-confirmation-server-functions

  dgcohen

  committed
  1e5a85a

• Update changelog

  dgcohen

  committed
  c2cf8c3

• Remove ternaries from HoldConfirmationItemDetails

  dgcohen

  committed
  122cded

• Comment out eligibility fetch

  dgcohen

  committed
  82533e8

• Restore fragment syntax

  dgcohen

  committed
  52a1e65

Commits on Dec 11, 2024

• Pass list children as props in detail element

  dgcohen

  committed
  5ba879f

• Remove fragment

  dgcohen

  committed
  702b3ec

• Restore fragments

  dgcohen

  committed
  1645a55

• Remove bib and item initialization from getServerSideProps

  dgcohen

  committed
  dbc84d1

• Fix comment

  dgcohen

  committed
  fdf92d6

Commits on Dec 12, 2024

• Remove winston line

  dgcohen

  committed
  e89a976