Code

SCC-3762 - Patron Eligibility Errors#415

Code

Merged

dgcohen merged 11 commits intohold-pagesNYPL/research-catalog:hold-pagesfrom SCC-3762/patron-eligibility-errorsNYPL/research-catalog:SCC-3762/patron-eligibility-errorsCopy head branch name to clipboardDec 17, 2024

+736-328

Commits

Commits on Dec 12, 2024

• Manually fix merge conflicts

  dgcohen

  committed
  4fb4f0e

• Fix eligibility type

  dgcohen

  committed
  dc86933

Commits on Dec 16, 2024

• Use constant for copy in test

  dgcohen

  committed
  5915469

• Remove optional chaining from patronIds

  dgcohen

  committed
  90427b0

• Remove destructuring of hold request id to trigger useful error logging

  dgcohen

  committed
  6d90c08

• Restore null check on patron ID for tests

  dgcohen

  committed
  8b9e05b

• Change ineligibiltiy reasons to children rather than list item props

  dgcohen

  committed
  e1ea60a

• Remove unused imports

  dgcohen

  committed
  1d8a265

• Extract failed request error state function

  dgcohen

  committed
  f662bb1

• Extract server error handler

  dgcohen

  committed
  565582e

• Remove ternary in hold error banner

  dgcohen

  committed
  ca74cf4