SCC-4389: My Account 2.0 QA round 1 and VQA/a11y round 2

[7emansell]

Ticket:

• JIRA ticket SCC-4389

This PR does the following:

Resolves the following issues:

a11y:

• When activating an Edit button, when there are multiple fields focus is moving to the last one when it seems more logical to move to the first
• Each phone/email label should be named uniquely - if one is primary, include that in the label, and then you could increment the labels for additional items. Do the same for trash labels.

QA:

• Add email button should display for accounts with no email
• Notification preference dropdown should disable phone or email as options if you don’t have them **
• Notification preference “Edit” button should be disabled if you don’t have phone or email to change it to, and display a banner with “Please set a phone number or email address to choose a notification preference.” **
• Status banner text should not repeat itself (currently, when you try an already taken username, it says “This username already exists. Please try a different username or contact us for assistance. Please try again or contact us for assistance.”)
• Add email/phone button should also be disabled while another field is being edited (like the Edit buttons disappearing)

** New product requirements, introduced 12/12

How has this been tested?

Most of these updates can only be seen on an account that has no attached phone number or email, and has its notification preference set to None. Use this one: 25555001351471 / 1082 but DO NOT actually Save Changes on an email/phone or on the notification preference, so that you can both see what's going on :)

Accessibility concerns or updates

Checklist:

• I updated the CHANGELOG with the appropriate information and JIRA ticket number (if applicable).
• I have added relevant accessibility documentation for this pull request.
• All new and existing tests passed.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
research-catalog	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 2:56pm

[charmingduchess]

it looks like this same check is used twice. can you pull it out into a variable?

[7emansell]

now isNotification

[EdwinGuzman]

Nice!

[7emansell]

Vera confirmed offline that it's good to go so I am dismissing her review

Confirmed offline that it's good to go