-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scc 4142/spec coll messaging #421
base: special-collections
Are you sure you want to change the base?
Scc 4142/spec coll messaging #421
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/models/ItemAvailability.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this functionality needs its own class? I feel like the key building could be added to the item model with a component handling the presentation logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's so focused on a specific cluster of data that I think it justifies its own class. I am going to move the presentation logic to the component.
This is a preliminary refactor to facilitate this ticket. Would love some eyes on this before I go all the way down this path.
To summarize, I created an ItemAvailability model which builds a string that represents it's availability, location, and special collections status. The model also handles returning the correct message component.
Ticket:
This PR does the following:
How has this been tested?
Accessibility concerns or updates
Checklist: