Skip to content

Commit

Permalink
Merge pull request #461 from NYPL/development
Browse files Browse the repository at this point in the history
Release 0.17.5 to production
  • Loading branch information
jackiequach authored Nov 16, 2023
2 parents ba23acb + 1ea0cf6 commit 27b4e46
Show file tree
Hide file tree
Showing 60 changed files with 5,080 additions and 3,935 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/Playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ on:
schedule:
- cron: "00 14 * * 1-5"
pull_request:
branches: [production]
types: [opened, synchronize, reopened]

branches: [production]
types: [opened, synchronize, reopened]

jobs:
tests:
Expand All @@ -27,17 +26,18 @@ jobs:
run: npx playwright install --with-deps

- name: Set the world parameters as an env var
# WORLD_PARAMETERS set here will override anything set in cucumber.json
run: |
echo "WORLD_PARAMETERS={\"appUrl\": \"https://digital-research-books-beta.nypl.org\", \"headless\": true}" >> $GITHUB_ENV
echo "WORLD_PARAMETERS={\"headless\": true}" >> $GITHUB_ENV
- name: Run Cucumber tests
run: npm run cucumber -- playwright/features --world-parameters '${{ env.WORLD_PARAMETERS }}'
env:
"catalog username": ${{ secrets.CATALOG_USERNAME }}
"catalog password": ${{ secrets.CATALOG_USER_PIN }}
CATALOG_USERNAME: ${{ secrets.CATALOG_USERNAME }}
CATALOG_USER_PIN: ${{ secrets.CATALOG_USER_PIN }}
CUCUMBER_PUBLISH_TOKEN: ${{ secrets.CUCUMBER_PUBLISH_TOKEN }}
CUCUMBER_PUBLISH_ENABLED: true

- name: Slack Notification
if: ${{ always() }}
uses: rtCamp/action-slack-notify@v2
Expand All @@ -46,4 +46,4 @@ jobs:
SLACK_MESSAGE: https://reports.cucumber.io/report-collections/01dbd6e8-653b-4597-b901-6caf2e653b07
SLACK_TITLE: DRB Cucumber/Playwright Test Results
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_USERNAME: nyplorgBot
SLACK_USERNAME: nyplorgBot
16 changes: 15 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
# CHANGE LOG

- Update production and qa builds to use unique ECR image tag
## [0.17.5]

- Fix: Small adjustments to Playwright tests
- Upgrade testing-library packages to v14 and jest to v29
- Remove TemplateFooter components
- Replace Template components with TemplateAppContainer and DrbBreakout to reduce repeat components
- Upgrade to NYPL Design System 2.1.0
- Replace fireEvent with userEvent
- Feedback button test PW
- SFR-1797: Remove Playwright tests with clicks on header and footer links
- Update README with C4 diagrams and epub-to-webpub info
- Update Collection, Edition, and Work page titles for accessibility
- Implement Typography changes from Reservoir 2.0
- Remove collection image alt text

## [0.17.4]

Expand All @@ -17,6 +30,7 @@
- Update Adobe Analytics page names
- SFR-1778: Fix failing Playwright tests
- SFR-1752: Remove rspec workflow
- Update production and qa builds to use unique ECR image tag

## [0.17.3]

Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,18 @@ Term combinations
- Webpub reader: DRB serves an epub through the [webpub-viewer](https://github.com/NYPL-Simplified/webpub-viewer/tree/SFR-develop). DRB commonly does this for Gutenberg Project books.
- Download: DRB offers a link to download the book online. This is often done for PDFs.

### EPUB to Webpub

The EPUB to Webpub Next.js app is deployed at `https://epub-to-webpub.vercel.app`. The **`/api/[containerXmlUrl]`** endpoint is used by the DRB backend to convert `container.xml` files of exploded EPUBs to webpub manifests.

### Test

To run unit tests, run `npm run test` in the terminal.

### C4 Architecture Diagrams

Diagrams for DRB can found via our public [Structurizr link](https://structurizr.com/share/72104) and can be updated in the (c4-diagrams repo)[https://github.com/NYPL-Simplified/c4-diagrams].

### Deprecated

As of September 2023, the [rspec-integration-tests.yml](https://github.com/NYPL/sfr-bookfinder-front-end/actions/workflows/rspec-integration-tests.yml) workflow is no longer in use and has been replaced by the [Playwright.yml](https://github.com/NYPL/sfr-bookfinder-front-end/blob/development/.github/workflows/Playwright.yml) workflow. Please contact the DRB team in Digital for more information.
10 changes: 6 additions & 4 deletions jest.config.js → jest.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// jest.config.js
const { defaults } = require("jest-config");
module.exports = {
import type { Config } from "jest";

const config: Config = {
moduleFileExtensions: ["js", "ts", "tsx"],
moduleNameMapper: {
"^~(.*)$": "<rootDir>$1",
Expand All @@ -11,9 +11,11 @@ module.exports = {
"testUtils",
"fixtures",
"componentHelpers",
"/playwright/"
"/playwright/",
],
setupFilesAfterEnv: ["./jest.setup.ts"],
resetMocks: true,
testEnvironment: "jsdom",
};

export default config;
Loading

0 comments on commit 27b4e46

Please sign in to comment.