Skip to content

Commit

Permalink
Merge pull request #485 from NYPL/NO-REF_fix_nr_missing_data
Browse files Browse the repository at this point in the history
NO-REF: Add APP_ENV var to build yml files
  • Loading branch information
jackiequach authored Mar 12, 2024
2 parents b58c4d5 + 3bae051 commit 3f6a77b
Show file tree
Hide file tree
Showing 5 changed files with 276 additions and 1,422 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build-production.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ jobs:

- name: Build, tag, and push image to Amazon ECR
env:
APP_ENV: production
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
ECR_REPOSITORY: sfr-front-end
IMAGE_TAG: ${{ github.sha }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build-qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:

- name: Build, tag, and push image to Amazon ECR
env:
APP_ENV: qa
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
ECR_REPOSITORY: sfr-front-end
IMAGE_TAG: ${{ github.sha }}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Hotfix: Update package-lock pdfjs-dist version
- Remove featured edition logic from frontend
- Chore: Add Krist, Jiayong, and Olivia as codeowners
- Add APP_ENV to yml files and update newrelic to v11.12.0

## [0.17.6]

Expand Down
Loading

0 comments on commit 3f6a77b

Please sign in to comment.