Skip to content

Commit

Permalink
Merge pull request #456 from NYPL/SFR-1822_remove_collection_alt_text
Browse files Browse the repository at this point in the history
SFR-1822: Remove collection image alt text
  • Loading branch information
jackiequach authored Nov 14, 2023
2 parents 64d995b + 25cec22 commit fb0f644
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
- SFR-1797: Remove Playwright tests with clicks on header and footer links
- Update README with C4 diagrams and epub-to-webpub info
- Update Collection, Edition, and Work page titles for accessibility
- Implement Typography changes from Reservoir 2.0
- Implement Typography changes from Reservoir 2.0
- Remove collection image alt text

## [0.17.4]

Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/Search.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ describe("Renders Search Results Page", () => {
name: "English (6)",
});
expect(englishCheckbox2).toBeChecked();
}, 15000);
}, 20000);
});
describe("Format filter", () => {
test("Clicking new format sends new search", async () => {
Expand Down
6 changes: 1 addition & 5 deletions src/components/CollectionCard/CollectionCard.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@ describe("Collection list", () => {
).toBeInTheDocument();
});
test("Shows cover", () => {
expect(
screen
.getByAltText("Cover for Baseball: A Collection by Mike Benowitz")
.closest("img").src
).toEqual(
expect(screen.getByAltText("").closest("img").src).toEqual(
"https://drb-files-qa.s3.amazonaws.com/misc/collectionPlaceholder.jpg"
);
});
Expand Down
2 changes: 1 addition & 1 deletion src/components/CollectionCard/CollectionCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const CollectionCard: React.FC<{ collection: Opds2Feed }> = ({
layout="column"
imageProps={{
src: PLACEHOLDER_LINK,
alt: `Cover for ${collection.metadata.title}`,
alt: ``,
aspectRatio: "twoByOne",
}}
mainActionLink={collection.links[0].href}
Expand Down

1 comment on commit fb0f644

@vercel
Copy link

@vercel vercel bot commented on fb0f644 Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.