Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.17.5 to production #461

Merged
merged 52 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
f03dd12
upgrade testing library to v14
jackiequach Sep 6, 2023
5e64141
Merge branch 'development' into SFR-1689_upgrade_testing_library
jackiequach Sep 6, 2023
b5c1b02
add timeout for year filter tests
jackiequach Sep 6, 2023
3a58664
fix test timeout fails
jackiequach Sep 7, 2023
a542144
remove unused import
jackiequach Sep 7, 2023
221447f
try no delay for userEvent
jackiequach Sep 7, 2023
358c102
Small adjustments to Playwright tests (#442)
samanthaandrews Sep 11, 2023
d844b72
Merge branch 'development' into SFR-1689_upgrade_testing_library
jackiequach Sep 12, 2023
3890fc5
Merge pull request #437 from NYPL/SFR-1689_upgrade_testing_library
jackiequach Sep 14, 2023
0c864b0
remove TemplateFooter and upgrade ds
jackiequach Sep 14, 2023
69323e9
Merge branch 'development' into SFR-1721_remove_template_footer
jackiequach Sep 14, 2023
6e88eda
update package-lock
jackiequach Sep 14, 2023
a6b0f48
update hero background image
jackiequach Sep 14, 2023
27a73bd
replace template components with DrbTemplate
jackiequach Sep 15, 2023
adf7b63
update prop name
jackiequach Sep 18, 2023
7e15dc3
update component composition
jackiequach Sep 19, 2023
3060540
Merge pull request #444 from NYPL/SFR-1721_remove_template_footer
jackiequach Sep 21, 2023
88d90c7
replace fireEvent with userEvent
jackiequach Sep 26, 2023
4e146d6
Merge branch 'development' into SFR-1780_replace_fireEvent
jackiequach Sep 26, 2023
5dbd0b3
increase timeout
jackiequach Sep 27, 2023
1b8080c
replace DrbTemplate with TemplateAppContainer
jackiequach Sep 27, 2023
ee6dbd3
update snapshots
jackiequach Sep 27, 2023
02757ca
Merge pull request #445 from NYPL/SFR-1780_replace_fireEvent
jackiequach Sep 29, 2023
7cc523c
Merge pull request #446 from NYPL/SFR-1721_fix_issues_from_qa
jackiequach Sep 29, 2023
675a54a
Sfr 1757/automate feedback button (#448)
ayan1229 Oct 16, 2023
399604d
implement typography changes
jackiequach Oct 20, 2023
8746216
update link styles
jackiequach Oct 23, 2023
a21f2e2
SFR-1797: Remove clicks on header and footer links in Playwright test…
clarissarichard Oct 24, 2023
5140ad7
update readme
jackiequach Oct 24, 2023
9c991c2
Merge branch 'development' into SFR-1760_update_readme_epubtowebpub
jackiequach Oct 24, 2023
314c191
Merge pull request #452 from NYPL/SFR-1760_update_readme_epubtowebpub
jackiequach Oct 24, 2023
a411e24
update page titles for accessibility
jackiequach Oct 26, 2023
ecfcba0
use template literals
jackiequach Oct 30, 2023
b8f699b
fix heading hierarchy
jackiequach Oct 30, 2023
167fb4b
Merge branch 'development' into SFR-1807_reservoir-2.0-upgrade
jackiequach Oct 30, 2023
93dc241
more hierarchy changes
jackiequach Oct 30, 2023
eded581
update page title truncation
jackiequach Nov 1, 2023
38e2fb3
fix failing test
jackiequach Nov 1, 2023
8482801
Merge pull request #454 from NYPL/SFR-1799_update-page-titles
jackiequach Nov 1, 2023
a0d35ba
fix vqa issues
jackiequach Nov 6, 2023
6166bb8
Merge branch 'development' into SFR-1807_reservoir-2.0-upgrade
jackiequach Nov 6, 2023
23919af
fix build issue
jackiequach Nov 6, 2023
c63dfb1
more vqa changes
jackiequach Nov 6, 2023
6dcfb5c
fix vqa issues round 2
jackiequach Nov 7, 2023
2e8942d
change spacing between author and card
jackiequach Nov 7, 2023
64d995b
Merge pull request #451 from NYPL/SFR-1807_reservoir-2.0-upgrade
jackiequach Nov 7, 2023
e1b68b8
remove collection alt text
jackiequach Nov 9, 2023
66519a9
update test
jackiequach Nov 9, 2023
25cec22
increase test timeout
jackiequach Nov 9, 2023
fb0f644
Merge pull request #456 from NYPL/SFR-1822_remove_collection_alt_text
jackiequach Nov 14, 2023
7acd472
update version number
jackiequach Nov 16, 2023
1ea0cf6
Merge pull request #458 from NYPL/NO-REF_prepare_0.17.5
jackiequach Nov 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/Playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ on:
schedule:
- cron: "00 14 * * 1-5"
pull_request:
branches: [production]
types: [opened, synchronize, reopened]

branches: [production]
types: [opened, synchronize, reopened]

jobs:
tests:
Expand All @@ -27,17 +26,18 @@ jobs:
run: npx playwright install --with-deps

- name: Set the world parameters as an env var
# WORLD_PARAMETERS set here will override anything set in cucumber.json
run: |
echo "WORLD_PARAMETERS={\"appUrl\": \"https://digital-research-books-beta.nypl.org\", \"headless\": true}" >> $GITHUB_ENV
echo "WORLD_PARAMETERS={\"headless\": true}" >> $GITHUB_ENV

- name: Run Cucumber tests
run: npm run cucumber -- playwright/features --world-parameters '${{ env.WORLD_PARAMETERS }}'
env:
"catalog username": ${{ secrets.CATALOG_USERNAME }}
"catalog password": ${{ secrets.CATALOG_USER_PIN }}
CATALOG_USERNAME: ${{ secrets.CATALOG_USERNAME }}
CATALOG_USER_PIN: ${{ secrets.CATALOG_USER_PIN }}
CUCUMBER_PUBLISH_TOKEN: ${{ secrets.CUCUMBER_PUBLISH_TOKEN }}
CUCUMBER_PUBLISH_ENABLED: true

- name: Slack Notification
if: ${{ always() }}
uses: rtCamp/action-slack-notify@v2
Expand All @@ -46,4 +46,4 @@ jobs:
SLACK_MESSAGE: https://reports.cucumber.io/report-collections/01dbd6e8-653b-4597-b901-6caf2e653b07
SLACK_TITLE: DRB Cucumber/Playwright Test Results
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_USERNAME: nyplorgBot
SLACK_USERNAME: nyplorgBot
16 changes: 15 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
# CHANGE LOG

- Update production and qa builds to use unique ECR image tag
## [0.17.5]

- Fix: Small adjustments to Playwright tests
- Upgrade testing-library packages to v14 and jest to v29
- Remove TemplateFooter components
- Replace Template components with TemplateAppContainer and DrbBreakout to reduce repeat components
- Upgrade to NYPL Design System 2.1.0
- Replace fireEvent with userEvent
- Feedback button test PW
- SFR-1797: Remove Playwright tests with clicks on header and footer links
- Update README with C4 diagrams and epub-to-webpub info
- Update Collection, Edition, and Work page titles for accessibility
- Implement Typography changes from Reservoir 2.0
- Remove collection image alt text

## [0.17.4]

Expand All @@ -17,6 +30,7 @@
- Update Adobe Analytics page names
- SFR-1778: Fix failing Playwright tests
- SFR-1752: Remove rspec workflow
- Update production and qa builds to use unique ECR image tag

## [0.17.3]

Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,18 @@ Term combinations
- Webpub reader: DRB serves an epub through the [webpub-viewer](https://github.com/NYPL-Simplified/webpub-viewer/tree/SFR-develop). DRB commonly does this for Gutenberg Project books.
- Download: DRB offers a link to download the book online. This is often done for PDFs.

### EPUB to Webpub

The EPUB to Webpub Next.js app is deployed at `https://epub-to-webpub.vercel.app`. The **`/api/[containerXmlUrl]`** endpoint is used by the DRB backend to convert `container.xml` files of exploded EPUBs to webpub manifests.

### Test

To run unit tests, run `npm run test` in the terminal.

### C4 Architecture Diagrams

Diagrams for DRB can found via our public [Structurizr link](https://structurizr.com/share/72104) and can be updated in the (c4-diagrams repo)[https://github.com/NYPL-Simplified/c4-diagrams].

### Deprecated

As of September 2023, the [rspec-integration-tests.yml](https://github.com/NYPL/sfr-bookfinder-front-end/actions/workflows/rspec-integration-tests.yml) workflow is no longer in use and has been replaced by the [Playwright.yml](https://github.com/NYPL/sfr-bookfinder-front-end/blob/development/.github/workflows/Playwright.yml) workflow. Please contact the DRB team in Digital for more information.
10 changes: 6 additions & 4 deletions jest.config.js → jest.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// jest.config.js
const { defaults } = require("jest-config");
module.exports = {
import type { Config } from "jest";

const config: Config = {
moduleFileExtensions: ["js", "ts", "tsx"],
moduleNameMapper: {
"^~(.*)$": "<rootDir>$1",
Expand All @@ -11,9 +11,11 @@ module.exports = {
"testUtils",
"fixtures",
"componentHelpers",
"/playwright/"
"/playwright/",
],
setupFilesAfterEnv: ["./jest.setup.ts"],
resetMocks: true,
testEnvironment: "jsdom",
};

export default config;
Loading
Loading