Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-1868: Limited access #475

Merged
merged 30 commits into from
Feb 14, 2024
Merged

SFR-1868: Limited access #475

merged 30 commits into from
Feb 14, 2024

Conversation

jackiequach
Copy link
Collaborator

@jackiequach jackiequach commented Jan 5, 2024 •
edited
Loading

Jira Ticket

This PR does the following:

  • Implements limited access for UP download links

Testing requirements & instructions:

jackiequach and others added 17 commits December 11, 2023 17:12
@jackiequach
add physical edition badge
757e1a7
@jackiequach
Merge branch 'development' into SFR-1854_physical_edition_badge
046c0b1
@jackiequach
update tests
ee19270
@jackiequach
render components directly
a400180
@jackiequach
Merge pull request #471 from NYPL/SFR-1854_physical_edition_badge
220107f 
SFR-1854: Add physical edition badge
@jackiequach
add new badges and update styles
82a0246
@jackiequach
update tests
51905a0
@jackiequach
fix some mobile styles
f7e539e
@jackiequach
update search tests
fcbc088
@jackiequach
update gap between ctas
b0c272a
@jackiequach
fix mobile card overflow issue
8d40b4a
@jackiequach
address comments
d727900
@jackiequach
fix test errors
9d4cb48
@jackiequach
refactor ResultsList and resolve VQA issues
7c1514f
@jackiequach
Merge pull request #472 from NYPL/SFR-1855_new_badges
150319a 
SFR-1855: Add Library Card Required and Featured Edition badges
@jackiequach
add limited access ctas
92a5c94
@jackiequach
Merge pull request #473 from NYPL/SFR-1856_limited_access_cta
43f44e3 
SFR-1856: Add Limited Access CTAs
@vercel Vercel
Copy link

vercel bot commented Jan 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 6:29pm

@jackiequach jackiequach changed the title [WIP] Limited access SFR-1868: Limited access Feb 14, 2024
@jackiequach jackiequach marked this pull request as ready for review February 14, 2024 18:30
@jackiequach
Copy link
Collaborator Author

Creating separate tickets for error handling and adding Playwright tests. We should merge this into QA so Ayan can get started on testing.

@jackiequach jackiequach merged commit 3c96566 into development Feb 14, 2024
7 checks passed
@jackiequach jackiequach deleted the limited-access branch February 14, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samanthaandrews samanthaandrews samanthaandrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackiequach @samanthaandrews