Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-1905: Add build arg to yml files #491

Merged
merged 3 commits into from
Mar 28, 2024
Merged

SFR-1905: Add build arg to yml files #491

merged 3 commits into from
Mar 28, 2024

Conversation

jackiequach
Copy link
Collaborator

Jira Ticket

This PR does the following:

  • Previously had added the env var for APP_ENV to the yml build files, but did not include it as a build-arg for the docker build command.

Testing requirements & instructions:

@vercel Vercel
Copy link

vercel bot commented Mar 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 7:09pm

samanthaandrews
samanthaandrews approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@samanthaandrews samanthaandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Wondering if you were able to test this locally to make sure data is going through to NR with this dockerfile update?

@jackiequach
Copy link
Collaborator Author

Updated dockerfile with env var after testing locally. It works correctly now.

@jackiequach jackiequach merged commit 272d2ae into development Mar 28, 2024
7 checks passed
@jackiequach jackiequach deleted the SFR-1905_fix_new_relic_missing_data branch March 28, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samanthaandrews samanthaandrews samanthaandrews approved these changes

@kristojorg kristojorg Awaiting requested review from kristojorg

@Toxiapo Toxiapo Awaiting requested review from Toxiapo

@oliviawongnyc oliviawongnyc Awaiting requested review from oliviawongnyc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackiequach @samanthaandrews