SFR-2154: Implement general error page designs #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackiequach
changed the title
jackiequach
requested review from
samanthaandrews,
kristojorg,
Toxiapo and
oliviawongnyc
as code owners
src/__tests__/testUtils/render.tsx
Outdated
| import { render, RenderOptions } from "@testing-library/react"; | ||
| import { ReactElement } from "react"; | ||
| import { FeatureFlagProvider } from "~/src/context/FeatureFlagContext"; | ||
| import { FeedbackProvider } from "~/src/context/FeedbackContext"; | ||
|
|
||
| const AllTheProviders = ({ children }) => { |
There was a problem hiding this comment.
Would Providers as a name work here?
Comment on lines
+35
to
+40
| 400: { | ||
| overline: "error 500", | ||
| heading: "There was an unexpected error.", | ||
| subText: "We couldn't process your request at this time. ", | ||
| tryText: "Try refreshing the page or ", | ||
| }, |
There was a problem hiding this comment.
Hmm 400 means that the request input was invalid. Should we reflect that accordingly in the text?
|
Overall, looks good! Just a few minor questions and comments. One thing that I have found helpful in the past when implementing the designs is to link to the Figma directly in the PR description. What is also good is to take screenshots of the different stages/pages. This is helpful for the reviewer to just help spot check between the designs and what is implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Figma Designs
This PR does the following:
Testing requirements & instructions: