Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2236: Update license link to copyright #535

Merged
merged 3 commits into from
Oct 9, 2024
Merged

SFR-2236: Update license link to copyright #535

merged 3 commits into from
Oct 9, 2024

Conversation

jackiequach
Copy link
Collaborator

Jira Ticket

This PR does the following:

  • Update license to copyright on edition, work, and collection cards

Testing requirements & instructions:

@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 7:40pm

kylevillegas93
kylevillegas93 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@kylevillegas93 kylevillegas93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!

There were a lot of updates to the tests for such a small change. Could we get the element by something else, e.g. ids or classes?

@samanthaandrews
Copy link
Contributor

Overall looks good!

There were a lot of updates to the tests for such a small change. Could we get the element by something else, e.g. ids or classes?

The trend in frontend testing is to (as much as possible) identify elements by what a user would see, so I think changing the tests in this case is the right move.

@jackiequach jackiequach merged commit 74c0893 into development Oct 9, 2024
8 checks passed
@jackiequach jackiequach deleted the SFR-2236/edition-license-link branch October 9, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylevillegas93 kylevillegas93 kylevillegas93 approved these changes

@samanthaandrews samanthaandrews Awaiting requested review from samanthaandrews samanthaandrews is a code owner

@kristojorg kristojorg Awaiting requested review from kristojorg

@Toxiapo Toxiapo Awaiting requested review from Toxiapo

@oliviawongnyc oliviawongnyc Awaiting requested review from oliviawongnyc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackiequach @samanthaandrews @kylevillegas93