Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-REF: Fixing docker file and playwright tests #547

Merged
merged 10 commits into from
Oct 25, 2024
Merged

NO-REF: Fixing docker file and playwright tests #547

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2800cc2
NO-REF: Fixing docker deploy
kylevillegas93 Oct 23, 2024
84c7e1a
updating change log
kylevillegas93 Oct 24, 2024
7713ffb
Fixing tests
kylevillegas93 Oct 24, 2024
6991e3b
trying to fix build
kylevillegas93 Oct 24, 2024
1f1b1a0
let us see
kylevillegas93 Oct 24, 2024
7bcd36b
fixing tests
kylevillegas93 Oct 24, 2024
61f602a
last little bits
kylevillegas93 Oct 24, 2024
4a23590
fixing text
kylevillegas93 Oct 24, 2024
acd4b0a
removing playwright tests for now
kylevillegas93 Oct 24, 2024
f50ec53
updating changelog
kylevillegas93 Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ ARG NEXT_PUBLIC_ADOBE_ANALYTICS
ARG APP_ENV

# Build the app!
RUN npm run build

ENV PATH /app/node_modules/.bin:$PATH
ENV PORT=3000 \
NODE_ENV=production
Expand All @@ -32,6 +30,8 @@ ENV NEW_RELIC_APP_NAME $NEW_RELIC_APP_NAME
ENV NEXT_PUBLIC_ADOBE_ANALYTICS $NEXT_PUBLIC_ADOBE_ANALYTICS
ENV APP_ENV $APP_ENV

RUN npm run build

# RUNNER, copy all the files and run next
FROM base AS runner
WORKDIR /app
Expand Down
2 changes: 0 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
version: "3"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version is obsolete!

services:
web:
container_name: sfr-bookfinder-front-end
Expand Down
Loading