SFR-2078: Automate Different Publishing Sources #554
Conversation
ayan1229
requested review from
samanthaandrews,
jackiequach,
kristojorg,
Toxiapo and
oliviawongnyc
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -0,0 +1,32 @@ | |||
| Feature: Specific Pub Sources | |||
There was a problem hiding this comment.
Im not quite sure I understand playwright feature testing. Is this the outline of test cases to be automated or does this actually these scenarios live on localhost?
There was a problem hiding this comment.
This is cucumber test scenarios. Basically all these steps are being tested and test steps are dynamically written in our test folder. Cucumber is used for easier documentation and quick test writing.
There was a problem hiding this comment.
Ok thanks! I understand.
These test scenarios are brittle and verbose.
I recommend considering breaking out the specific functionality to test:
- Search functionality - ensure search results show up as expected given a very generic query
- Reader functionality - ensure a specific file/type or source is readable.
There was a problem hiding this comment.
Since we've added Playwright & Cucumber to the app, I've learned a lot more about how to structure Playwright tests, and the general best practice is to use a page object model. As an example, you can see how we are doing this in pjr: each page has its own folder that contains a spec file and a corresponding page file.
Also, I'd like to re-evaluate if we need to use Cucumber at all. Imo the layer of abstraction it provides doesn't provide any value and adds unnecessary complexity.
My recommendation would be to remove Cucumber and begin refactoring our tests to use the page object model.
Jira Ticket
This PR does the following:
OAPEN PDF: How safe is eating chicken?
Gutenberg ePub: Chicken Farm
Project Muse PDF: Reading fiction in antebellum America
IntechOpen PDF: Climate Change and Agriculture