Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.18.9 to production #565

Merged
merged 15 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 0 additions & 101 deletions .eslintrc.js

This file was deleted.

18 changes: 18 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"extends": [
"eslint:recommended",
"next",
"next/core-web-vitals",
"next/typescript",
"plugin:jest-dom/recommended",
"plugin:jsx-a11y/strict",
"plugin:testing-library/dom",
"prettier",
"prettier/@typescript-eslint"
],
"rules": {
// TODO: SFR-2318 enable in the future
"@typescript-eslint/no-explicit-any": "off",
"testing-library/no-node-access": "off"
}
}
20 changes: 4 additions & 16 deletions .github/workflows/Playwright.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
name: Playwright Tests for Digital Research Books

# TODO: Remove https://drb-api-qa.nypl.org from behind the VPC
# on:
# pull_request:
on:
pull_request:

jobs:
tests:
Expand All @@ -26,20 +25,9 @@ jobs:
run: NODE_ENV=test npm run build

- name: Start the app
run: npm run dev &
shell: bash

- name: Wait for the app
run: |
RETRIES=6
until curl --output /dev/null --silent --head --fail http://localhost:3000 || [ $((RETRIES--)) -eq 0 ]; do
echo "Waiting for http://localhost:3000"
sleep 5
done
if [ $RETRIES -lt 0 ]; then
echo "Failed to connect to http://localhost:3000"
exit 1
fi
NODE_ENV=test npm start &
sleep 5
shell: bash

- name: Run your tests
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/build-qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,7 @@ jobs:
- name: Force ECS Update
run: |
aws ecs update-service --cluster sfr-front-end-qa --service sfr-front-end-qa --force-new-deployment

- name: Force ECS Update - Terraform
run: |
aws ecs update-service --cluster sfr-frontend-qa-tf --service sfr-frontend-qa-tf --force-new-deployment
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# CHANGE LOG

## [Prerelease]

## [0.18.9]

- Enable playwright tests GH action
- Remove unused scss and img files
- Remove duplicate eslint packages, update eslint config, and resolve linting errors
- Update survey banner to be more visible
- Deploy to both ECS clusters in QA

## [0.18.8]

- Add survey banner to Landing, Collection, Edition, Work, and Search pages
Expand Down
Loading
Loading