src/queue.c: fix format-security warnings #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring. The syslog() function takes as its second argument a format string (a la printf), but if the third parameter is a string, then the format string can be omitted. This has led to security vulnerabilities in the past, and compilers can now warn about it. In particular, GCC has the -Wformat-security option, which can be made an error with -Werror=format-security. A few such two-argument calls were present in src/queue.c, where constant strings were being logged to syslog. This commit adds the second format string parameter (simply "%s" in this case) to avoid the compiler warnings. More information about format-security can be found in Fedora's FAQ: https://fedoraproject.org/wiki/Format-Security-FAQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
syslog()function takes as its second argument a format string (a la printf), but if the third parameter is a string, then the format string can be omitted. This has led to security vulnerabilities in the past, and compilers can now warn about it. In particular, GCC has the-Wformat-securityoption, which can be made an error with-Werror=format-security.A few such two-argument calls were present in
src/queue.c, where constant strings were being logged to syslog. This commit adds the second format string parameter (simply "%s" in this case) to avoid the compiler warnings.More information about format-security can be found in Fedora's FAQ