Add UserUpdatedEvent #3504
Draft
Add UserUpdatedEvent #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadhgboyle
reviewed
May 6, 2024
| $this->user = $user; | ||
|
|
||
| $data = DB::getInstance()->get('users', ['id', $user->data()->id]); | ||
| $this->updated_data = new UserData($data->first()); |
There was a problem hiding this comment.
Would be nice if we could provide something like data_before, data_after and then a diff of them via data_changed
There was a problem hiding this comment.
Well this PR did not really go as planned
I want to trigger certain functions when event is triggered but as the functions require User param it will get the outdated data :/
Like to solve that i need to directly update userData on update
foreach ($fields as $key => $value) {
$this->data()->{$key} = $value;
}
But updating the userdata directly could have bad side effects idk
Another problem i also have is integrations cache is outdated if any integrations is added/removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UserUpdatedEvent allows modules to eaiser detect user changes like when username change
Will need to discover possible places to execute event