Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If datatype is an uuid, do not use as regular field #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jyrkidn
Copy link
Contributor

@jyrkidn jyrkidn commented Oct 14, 2020

If you have an uuid now, it was also added as:

return [
    ID::make()->sortable(),

    Text::make('Team id')
        ->rules('required'),

    BelongsTo::make('Team'),

    DateTime::make('Created at'),
    DateTime::make('Updated at'),
];

The Text field was not necessary, with this update it will be removed and only the BelongsTo will be added.

@Naoray
Copy link
Owner

Naoray commented Oct 14, 2020

Hi @jyrkidn,

thanks for your contribution!

Could you point me to the update you are mentioning about the uuid columns? I don't seem to find anything about it.

@jyrkidn
Copy link
Contributor Author

jyrkidn commented Oct 14, 2020

@Naoray I meant the update in this pull request. Sorry if it was not clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants