feat: remove httpStatusCode b/w compat property

NaturalCycles · Jul 10, 2024 · dca780d · dca780d
1 parent 14f3fb6
commit dca780d
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 30 deletions.
diff --git a/src/server/__snapshots__/getDefaultRouter.test.ts.snap b/src/server/__snapshots__/getDefaultRouter.test.ts.snap
diff --git a/src/server/genericErrorMiddleware.ts b/src/server/genericErrorMiddleware.ts
@@ -35,7 +35,7 @@ let formatError: GenericErrorMiddlewareCfg['formatError']
 
 /**
  * Generic error handler.
- * Returns HTTP code based on err.data.httpStatusCode (default to 500).
+ * Returns HTTP code based on err.data.backendResponseStatusCode (default to 500).
  * Sends json payload as ErrorResponse, transformed via errorSharedUtil.
  */
 export function genericErrorMiddleware(
@@ -86,9 +86,6 @@ export function respondWithError(req: BackendRequest, res: BackendResponse, err:
 
   httpError.data.errorId = errorId
   httpError.data.backendResponseStatusCode ||= 500 // default to 500
-  // httpStatusCode is for backwards-compatibility
-  // Otherwise, it breaks the _isHttpErrorResponse function check, and error get formatted/detected wrongly
-  httpError.data['httpStatusCode'] = httpError.data.backendResponseStatusCode
   httpError.data.headersSent = headersSent || undefined
   _filterUndefinedValues(httpError.data, true)
 

diff --git a/src/server/validation/validateMiddleware.test.ts b/src/server/validation/validateMiddleware.test.ts
@@ -26,17 +26,16 @@ test('validateBody', async () => {
   expect(err.cause.message).not.toContain(pw)
   expect(err.cause.message).toContain('REDACTED')
   expect(err.cause).toMatchInlineSnapshot(`
-    {
-      "data": {
-        "backendResponseStatusCode": 400,
-        "errors": [],
-        "httpStatusCode": 400,
-        "objectName": "request body",
-        "userFriendly": true,
-      },
-      "message": "request body/pw must NOT have fewer than 8 characters
-    Input: { pw: 'REDACTED' }",
-      "name": "AppError",
-    }
-  `)
+{
+  "data": {
+    "backendResponseStatusCode": 400,
+    "errors": [],
+    "objectName": "request body",
+    "userFriendly": true,
+  },
+  "message": "request body/pw must NOT have fewer than 8 characters
+Input: { pw: 'REDACTED' }",
+  "name": "AppError",
+}
+`)
 })
diff --git a/src/server/validation/validateRequest.test.ts b/src/server/validation/validateRequest.test.ts
@@ -30,7 +30,6 @@ test('validateRequest', async () => {
 {
   "data": {
     "backendResponseStatusCode": 400,
-    "httpStatusCode": 400,
     "joiValidationErrorItems": [],
     "joiValidationObjectName": "request body",
   },