feat: add header validation utilities #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnagydavid
commented
Oct 21, 2024
Comment on lines
+57
to
+58
| numeric: jsonSchema.string(), | ||
| bool: jsonSchema.string(), |
There was a problem hiding this comment.
JsonSchema offers no casting or I didn't find it.
mrnagydavid
commented
Oct 21, 2024
| objectSchema<any>({ | ||
| shortstring: stringSchema.min(8).max(16), | ||
| numeric: numberSchema, | ||
| bool: stringSchema, |
There was a problem hiding this comment.
The booleanSchema does no casting, it simply screams in horror when it sees a string.
There was a problem hiding this comment.
Oh, I didn't believe it so I had to test myself, and indeed, you're right!
kirillgroshkov
approved these changes
Oct 21, 2024
| objectSchema<any>({ | ||
| shortstring: stringSchema.min(8).max(16), | ||
| numeric: numberSchema, | ||
| bool: stringSchema, |
There was a problem hiding this comment.
Oh, I didn't believe it so I had to test myself, and indeed, you're right!
|
🎉 This PR is included in version 5.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added header validation utilities in the shape of:
validateRequest.headersusing JOIvalidateHeadersusing JsonSchemaOne potentially unexpected effect of these functions is
that they will produce lowercase headers (as the standard dictates)
since they rely on
req.headerswhich contains lowercase keys.