fix: better timeout error fingerprinting

NaturalCycles · Aug 2, 2023 · 534452e · 534452e
1 parent bc24f78
commit 534452e
Show file tree

Hide file tree

Showing 3 changed files with 694 additions and 621 deletions.
diff --git a/src/DatastoreStreamReadable.ts b/src/DatastoreStreamReadable.ts
@@ -78,7 +78,7 @@ export class DatastoreStreamReadable<T = any> extends Readable implements Readab
         },
       )
     } catch (err) {
-      console.error(
+      console.log(
         `DatastoreStreamReadable error!\n`,
         {
           table: this.table,

diff --git a/src/datastore.db.ts b/src/datastore.db.ts
@@ -59,6 +59,8 @@ const RETRY_ON = [
 // Examples of errors:
 // UNKNOWN: Stream removed
 
+const DATASTORE_TIMEOUT = 'DATASTORE_TIMEOUT'
+
 const methodMap: Record<CommonDBSaveMethod, string> = {
   insert: 'insert',
   update: 'update',
@@ -154,7 +156,7 @@ export class DatastoreDB extends BaseCommonDB implements CommonDB {
           timeout: this.cfg.timeout,
           errorData: {
             // This error will be grouped ACROSS all endpoints and usages
-            fingerprint: ['DATASTORE_TIMEOUT'],
+            fingerprint: [DATASTORE_TIMEOUT],
           },
         })
         rows = r[0]
@@ -540,6 +542,9 @@ export class DatastoreDB extends BaseCommonDB implements CommonDB {
       logFailures: true,
       // logAll: true,
       logger: this.cfg.logger,
+      errorData: {
+        fingerprint: [DATASTORE_TIMEOUT],
+      },
     }
   }
 }