Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be merged (probably)
Problem statement
this was the original shape of the
testEntries
this is the current:
with this change the redis-lib manual tests (running this
keyValueDaoTest()
) fail:With the reversion shown in this PR, every test passes.
Since the Dao is defined in this lib and not in
redis-lib
, I don't think the issue should be fixed inredis-lib
.The
any
type is a smell, as it should beBuffer
- but then it raises other type errors.