feat: add incrementBatch support
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only Redis >=7.4.0 supports it. GCP MemStore is 7.0.12. Latest Redis for Mac is 7.2.6.
mrnagydavid
commented
Oct 18, 2024
| @@ -157,6 +159,25 @@ export class RedisClient implements CommonClient { | |||
| return await this.redis().hincrby(key, field, increment) | |||
| } | |||
|
|
|||
| async hincrBatch(key: string, incrementTuples: [string, number][]): Promise<[string, number][]> { | |||
There was a problem hiding this comment.
I added the batch support into our client-wrapper, because the withPipeline() exposes the underlying lib, and I don't think that consumers of our wrapper should be using that (if avoidable).
The consuming logic (redis*KeyValueDb.incrementBatch) has also its own business translating the keys - so this separation of concerns (here we pipe, there we translate ids) is also a plus,
mrnagydavid
commented
Oct 18, 2024
Comment on lines
+194
to
+201
| throw new Error('Not supported until Redis 7.4.0') | ||
| // const valueKeys = Object.keys(value) | ||
| // const numberOfKeys = valueKeys.length | ||
| // const keyList = valueKeys.join(' ') | ||
| // const commandString = `HEXPIREAT ${key} ${expireAt} FIELDS ${numberOfKeys} ${keyList}` | ||
| // const [command, ...args] = commandString.split(' ') | ||
| // await this.redis().hset(key, value) | ||
| // await this.redis().call(command!, args) |
There was a problem hiding this comment.
Thinking open source, this is probably not a good idea.
Maybe a version check, and then throw?
On the other hand, none of OUR usually accessible redises support it.
kirillgroshkov
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the new
db-libadditionincrementBatch.Also disabling
hsetWithTTLsupport because it is only supported >= 7.4.0.I implemented it on Linux with the latest Redis.
Turns out that: