Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use hash fields as table namespace #18

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

mrnagydavid
Copy link
Contributor

In this PR, I added a new candidate for RedisKeyValueDB (not exported yet),
which uses hash fields as table namespace.

One caveat so far is the expiring fields feature.
While "proper" fields support EXAT expiry,
the hash fields have expiry support only with 7.4.0.

Which means that in all usecases where this matters, the original RedisKeyValueDB implementation is the one to go with.

Copy link
Member

@kirillgroshkov kirillgroshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, super smooth!

src/redisKeyValueDB2.ts Outdated Show resolved Hide resolved
src/redisKeyValueDB2.ts Outdated Show resolved Hide resolved
src/redisKeyValueDB2.ts Outdated Show resolved Hide resolved
@mrnagydavid mrnagydavid marked this pull request as ready for review October 18, 2024 14:47
@mrnagydavid mrnagydavid merged commit 9dec99d into master Oct 18, 2024
2 checks passed
@mrnagydavid mrnagydavid deleted the feat/use-hashfields-for-tables branch October 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants