Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #25 #26

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Resolve #25 #26

merged 1 commit into from
Dec 12, 2023

Conversation

daejoon
Copy link
Collaborator

@daejoon daejoon commented Dec 11, 2023

🚀 Description

Resolve #25

📄 Motivation and Context

🧪 How Has This Been Tested?

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@daejoon daejoon requested a review from Nayacco December 12, 2023 05:17
@natros
Copy link

natros commented Dec 12, 2023

I compiled it locally with your patch and it works without errors

@Nayacco
Copy link
Owner

Nayacco commented Dec 12, 2023

Thank you all for your support. I will release it tonight.

@Nayacco Nayacco merged commit 729c4ea into main Dec 12, 2023
5 checks passed
@daejoon daejoon deleted the bugfix/issue-25 branch December 13, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nayacco Nayacco Awaiting requested review from Nayacco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read access is allowed from inside read-action
3 participants
@daejoon @natros @Nayacco