Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fpRelPowerSeriesRing supertype #1884

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

lgoettgens
Copy link
Collaborator

This resolves the issue found by @fingolfin in #1883 (comment).

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (1b3e5dd) to head (8d9eabd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
- Coverage   87.47%   87.44%   -0.03%     
==========================================
  Files          97       97              
  Lines       35664    35664              
==========================================
- Hits        31196    31187       -9     
- Misses       4468     4477       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@fingolfin fingolfin merged commit e2c1ddf into Nemocas:master Oct 8, 2024
24 of 25 checks passed
@lgoettgens lgoettgens deleted the lg/fpRelPowerSeriesRing branch November 8, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants