Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issues): create and list #693

Merged
merged 5 commits into from
Nov 3, 2024

Conversation

kavitha186
Copy link
Collaborator

@kavitha186 kavitha186 commented Feb 4, 2024

This PR is for the feature to post issues on the repositories with shepherd. if you are looking to post issues across multiple repositories, you can use the command "issue" to create, update , list posted issues and close issue

issue with the title, issue message, labels , state and state_reason provided in the migration scripts.

This enhancement feature is for the issue #87 and #590

Screenshots

Create Issue

image image

Update Issue

image

Closing Issue

image image

List Issues

image

Screencasts

Screen-2024-03-17-185925.mp4

@kavitha186 kavitha186 force-pushed the feat-create-issue branch 9 times, most recently from 3b65c3b to f1dcac3 Compare February 8, 2024 02:15
@aorinevo aorinevo changed the base branch from main to feat/create-issues-labels February 11, 2024 18:07
@aorinevo aorinevo force-pushed the feat/create-issues-labels branch from defbb83 to 3bff297 Compare February 11, 2024 18:28
@aorinevo aorinevo changed the base branch from feat/create-issues-labels to main February 11, 2024 18:37
@aorinevo aorinevo changed the base branch from main to feat/create-issues-labels February 11, 2024 18:40
@aorinevo aorinevo self-requested a review February 11, 2024 18:41
@aorinevo aorinevo self-assigned this Feb 11, 2024
@aorinevo aorinevo added the enhancement New feature or request label Feb 11, 2024
@aorinevo
Copy link
Collaborator

aorinevo commented Feb 11, 2024

@kavitha186, we need unit tests to cover issue, list-issues, and list commands. Can you add those?

I've started down this road with checkout.ts. Seems a bit bulky and in need of rework but thought I'd share how I'm thinking about adding coverage for commands.

#697

package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@aorinevo
Copy link
Collaborator

@kavitha186, I've landed test coverage for all the existing commands. You should be good to go to do the same for the new commands introduced in this PR.

@kavitha186 kavitha186 changed the base branch from feat/create-issues-labels to main March 16, 2024 23:17
@kavitha186 kavitha186 force-pushed the feat-create-issue branch 3 times, most recently from 614b5e7 to f328e68 Compare March 17, 2024 03:12
@aorinevo
Copy link
Collaborator

@kavitha186, let’s add a screenshot of unit tests coverage. A recording demoing the functionality would be helpful too.

@kavitha186
Copy link
Collaborator Author

@kavitha186, let’s add a screenshot of unit tests coverage. A recording demoing the functionality would be helpful too.

image

@kavitha186 kavitha186 force-pushed the feat-create-issue branch 5 times, most recently from 2b5a342 to 2b6d751 Compare October 6, 2024 20:25
@aorinevo
Copy link
Collaborator

@kavitha186, I've created a v3 branch for the next major release of Shepherd. Let's use that branch instead of main for these changes.

@aorinevo aorinevo changed the base branch from main to v3 October 27, 2024 18:17
@kavitha186
Copy link
Collaborator Author

@aorinevo I rebased the branch from main previously. Is there anything required to be taken care from my end?

@aorinevo
Copy link
Collaborator

@aorinevo I rebased the branch from main previously. Is there anything required to be taken care from my end?

Plan is to land #852 and then this PR, both on v3 branch along with other features and enhancements. Once landed, let's switch local use to v3 and let it bake for a certain period of time before we merge v3 down to main and release the next major version.

What this means for this PR. Once CI failures are resolved and #852 is landed, we can merge this PR into v3 provided the changes comport with changes in #852. If not, it will likely require additional changes to this PR before landing.

@aorinevo
Copy link
Collaborator

aorinevo commented Nov 2, 2024

@kavitha186, when you get a chance, please resolve CI failures.

@kavitha186 kavitha186 force-pushed the feat-create-issue branch 8 times, most recently from 054eb98 to cb1681f Compare November 2, 2024 23:55
@kavitha186
Copy link
Collaborator Author

@kavitha186, when you get a chance, please resolve CI failures.

@aorinevo fixed the ci failures

@aorinevo aorinevo changed the title feat: create and list issues feat(issues): create and list Nov 3, 2024
@aorinevo aorinevo self-requested a review November 3, 2024 10:16
@aorinevo aorinevo merged commit 7b00e18 into NerdWalletOSS:v3 Nov 3, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants