Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astractl 33676: Make cloudId and clusterId optional #365

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jharrod
Copy link
Collaborator

@jharrod jharrod commented Jun 12, 2024

This PR adds the ability for clusterId and cloudID to be optionally provided in the connector CR spec.
If not provided, connector-operator will handle creating the pending cluster and private cloud if needed.

Manually tested:

  • No ClusterId, with cloudId and ClusterName
  • Cluster name only
  • CusterId, no cloudID or ClusterName
  • CloudID and clusterName provided (no clusterId)
  • No clusterId or cloud Id provided
  • Regular Install, clusterId and cloudId both provided
  • Bad cluster ID provided (proper err displayed)

@jharrod jharrod changed the title Astractl 33676 optional cloud id cluster Astractl 33676: Make cloudId and clusterId optional Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants