Skip to content

Commit

Permalink
feat: handled review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Hardikl committed Nov 28, 2024
1 parent 6767c60 commit ec47299
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions cmd/collectors/rest/testdata/conf/rest/9.12.1/volume.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ plugins:
- style style `flexgroup_constituent` `flexgroup`
- svm_root root_volume `false` `No`
- svm_root root_volume `true` `Yes`
# Ignore transient volumes, e.g. SnapProtect, SnapManager, SnapCenter, CommVault, Clone, and Metadata volumes
exclude_regex:
- volume `.+_CVclone`
- volume `.+(0[1-9]|[12][0-9]|3[01])(0[1-9]|1[012])\d\d[0-9]{6}`
Expand Down
1 change: 1 addition & 0 deletions conf/rest/9.12.0/volume.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ plugins:
- svm_root root_volume `false` `No`
- svm_root root_volume `true` `Yes`
- svm_root root_volume `^$` `Yes` # svm_root is not available in Rest response for volumes like vol0
# Ignore transient volumes, e.g. SnapProtect, SnapManager, SnapCenter, CommVault, Clone, and Metadata volumes
exclude_regex:
- volume `.+_CVclone`
- volume `.+(0[1-9]|[12][0-9]|3[01])(0[1-9]|1[012])\d\d[0-9]{6}`
Expand Down
1 change: 1 addition & 0 deletions conf/rest/9.14.0/volume.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ plugins:
- svm_root root_volume `false` `No`
- svm_root root_volume `true` `Yes`
- svm_root root_volume `^$` `Yes` # svm_root is not available in Rest response for volumes like vol0
# Ignore transient volumes, e.g. SnapProtect, SnapManager, SnapCenter, CommVault, Clone, and Metadata volumes
exclude_regex:
- volume `.+_CVclone`
- volume `.+(0[1-9]|[12][0-9]|3[01])(0[1-9]|1[012])\d\d[0-9]{6}`
Expand Down
1 change: 1 addition & 0 deletions conf/restperf/9.12.0/volume.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ plugins:
include_constituents: false

- LabelAgent:
# Ignore transient volumes, e.g. SnapProtect, SnapManager, SnapCenter, CommVault, Clone, and Metadata volumes
exclude_regex:
- volume `.+_CVclone`
- volume `.+(0[1-9]|[12][0-9]|3[01])(0[1-9]|1[012])\d\d[0-9]{6}`
Expand Down
1 change: 1 addition & 0 deletions conf/zapi/cdot/9.8.0/volume.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ plugins:
# metric label zapi_value rest_value `default_value`
value_to_num:
- new_status state online online `0`
# Ignore transient volumes, e.g. SnapProtect, SnapManager, SnapCenter, CommVault, Clone, and Metadata volumes
exclude_regex:
- volume `.+_CVclone`
- volume `.+(0[1-9]|[12][0-9]|3[01])(0[1-9]|1[012])\d\d[0-9]{6}`
Expand Down
1 change: 1 addition & 0 deletions conf/zapiperf/cdot/9.8.0/volume.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ plugins:
- Volume:
include_constituents: false
- LabelAgent:
# Ignore transient volumes, e.g. SnapProtect, SnapManager, SnapCenter, CommVault, Clone, and Metadata volumes
exclude_regex:
- volume `.+_CVclone`
- volume `.+(0[1-9]|[12][0-9]|3[01])(0[1-9]|1[012])\d\d[0-9]{6}`
Expand Down

0 comments on commit ec47299

Please sign in to comment.