285 review all modules name prior to 20 release #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenjun666
requested review from
carchi8py,
chuyich and
suhasbshekar
as code owners
Add supporting Amazon FSx for NetApp ONTAP
Add * Amazon FSx for NetApp ONTAP
add * Amazon FSx for NetApp ONTAP
update resource name on the test
fix import test
…ps://github.com/NetApp/terraform-provider-netapp-ontap into 285-review-all-modules-name-prior-to-20-release
chuyich
reviewed
Oct 9, 2024
|
|
||
| Name Services | ||
| * **Rename Resource:** `netapp-ontap_name_services_dns_resource` is now renamed to `netapp-ontap_dns` | ||
| * **Rename Resource:** `netapp-ontap_name_services_ldap_resource` is now renamed to `netapp-ontap_name_services_ldap` |
There was a problem hiding this comment.
Just curious, why the dns does not need the prefix "name_services" but ldap needs it?
There was a problem hiding this comment.
This is how I determine: In the VSIM, if you type dns, it knows exactly what dns. If you type ldap, it's ambiguous. Also in the API page, there are multiple ldap.
| * **Rename Data Source:** `netapp-ontap_networking_ip_routes_data_source` is now renamed to `netapp-ontap_network_ip_routes` | ||
|
|
||
| Protocols | ||
| * **Rename Resource:** `netapp-ontap_cifs_local_group_member_resource` is now renamed to `netapp-ontap_cifs_local_group_members` |
There was a problem hiding this comment.
Should "member" or "members"?
There was a problem hiding this comment.
"members", i check the API, you can create a group of members at one time. We haven't implemented it, but it is there.
| * **Rename Resource:** `netapp-ontap_cifs_local_user_resource` is now renamed to `netapp-ontap_cifs_local_user` | ||
| * **Rename Resource:** `netapp-ontap_cifs_service_resource` is now renamed to `netapp-ontap_cifs_service` | ||
| * **Rename Resource:** `netapp-ontap_cifs_share_resource` is now renamed to `netapp-ontap_cifs_share` | ||
| * **Rename Resource:** `netapp-ontap_cifs_user_group_privilege_resource` is now renamed to `netapp-ontap_cifs_user_group_privileges` |
There was a problem hiding this comment.
Should "privileges" or "privilege"?
There was a problem hiding this comment.
same as above, you can create a list of privileges at one time.
| * **Rename Resource:** `netapp-ontap_nfs_export_policy_rule_resource` is now renamed to `netapp-ontap_nfs_export_policy_rule` | ||
| * **Rename Resource:** `netapp-ontap_nfs_service_resource` is now renamed to `netapp-ontap_nfs_service` | ||
| * **Rename Resource:** `netapp-ontap_san_igroup_resource` is now renamed to `netapp-ontap_san_igroup` | ||
| * **Rename Resource:** `netapp-ontap_san_lun-maps_resource` is now renamed to `netapp-ontap_san_lun-map` |
| * **Rename Data Source:** `netapp-ontap_nfs_services_data_source` is now renamed to `netapp-ontap_nfs_services` | ||
| * **Rename Data Source:** `netapp-ontap_san_igroup_data_source` is now renamed to `netapp-ontap_san_igroup` | ||
| * **Rename Data Source:** `netapp-ontap_san_igroups_data_source` is now renamed to `netapp-ontap_san_igroups` | ||
| * **Rename Data Source:** `netapp-ontap_san_lun-map_data_source` is now renamed to `netapp-ontap_san_lun-map` |
carchi8py
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.